On Wed, Nov 15, 2017 at 12:16 AM, Parav Pandit <parav@xxxxxxxxxxxx> wrote: >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] >> Subject: Re: [PATCH rdma-next 28/31] IB/cm: Fix avoid sleep while spin lock is >>> From: Parav Pandit <parav@xxxxxxxxxxxx> >>> In case of LAP are used for RoCE >> AFAIK APM is not supported with RoCE, isn't that? if yes, on what HW/RoCE >> mode and how do you test that? > This particular patch in this series is not tested on RoCE. > APM is not supported but injecting such frame in network is not impossible. > We don’t have particular checks to reject such frame for RoCE. > So I prefer to fix the issue before getting such hang/oops report when issue is evident in code. mentioning testing, in this series you did bunch of fixes for the IB core, CM and CMA. Would be good to add a section in the cover letter mentioning under which type of testing the modified code has gone through. Seems that you did a hell of hardening to the IB core, cool!! -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
