> -----Original Message----- > From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] > Sent: Tuesday, November 14, 2017 4:18 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Hefty, > Sean <sean.hefty@xxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 27/31] IB/cm: Fix honor address handle attribute > init error > > On Wed, Nov 15, 2017 at 12:13 AM, Parav Pandit <parav@xxxxxxxxxxxx> > wrote: > >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] > > >> any reason not to point out the commit that introduced the bug? > > No particular reason. I am not sure few years back it was bug or not. In current > code it appear so. > > So I continued without Fixes commit line. > > > The idea is that you do the git blaming and such work to get the Fixes line, and > later, the maintainer of the sub-system and maintainers of stable kernel use that > to decide if/where they want this to go beyond the -rc kernel you are fixing Yes, I understand. But would that be a bug in initial commit, which transport was it handling.. without error code check what could have gone wrong.. I do not have answer for those questions. So I omitted the Fixes line. Wherever I knew for sure in this or other series, I have added. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f