On Wed, Nov 15, 2017 at 12:32 AM, Parav Pandit <parav@xxxxxxxxxxxx> wrote: >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] >> >>> In case of LAP are used for RoCE >> >> AFAIK APM is not supported with RoCE, isn't that? if yes, on what >> >> HW/RoCE mode and how do you test that? >> > This particular patch in this series is not tested on RoCE. >> > APM is not supported but injecting such frame in network is not impossible. >> > We don’t have particular checks to reject such frame for RoCE. >> > So I prefer to fix the issue before getting such hang/oops report when issue is >> evident in code. >> >> mentioning testing, in this series you did bunch of fixes for the IB core, CM and >> CMA. >> >> Would be good to add a section in the cover letter mentioning under which type >> of testing the modified code has gone through. > It's been tested for RoCEv1, v2, IPoIB with ConnectX4, ConnectX3 HCA with perftest, rping, krping tools. > In few individual patch, it's been mentioned how is this tested. Please also add more info (and in the cover letter please) on IPv4 vs IPv6, unicast vs multicast, etc. You touched the CMA and addr modules quite heavily on all these areas, need to cover them in testing. did you test APM? I don't think it would be correct to change the CM APM code without proper testing. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
