On Thu, Nov 16, 2017 at 1:10 AM, Parav Pandit <parav@xxxxxxxxxxxx> wrote: >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] >> Please also add more info (and in the cover letter please) on IPv4 vs IPv6, unicast >> vs multicast, etc. > Is there a template that you can share that linux-rdma follows that I can use to mention what tests are done? > Any example past cover letters that I can refer as reference? I suggest you ask the sub-system maintainers (Doug, Jason) what do they expect for such a heavy duty change set. > Depending on how much information you expect in cover letter, this patchset can have many revisions just for cover letter. > So it would be best for you to share the template that I can fill in for v1. You are still on V0 and complaining on many revisions... >> You touched the CMA and addr modules quite heavily on all these areas, need to >> cover them in testing. > Which are those tests that I should execute apart from above summary? If there is rdma verification suit @ mlnx that runs rdma user/kernel cm/cma based applications on ib/roce environments, can run through it. >> did you test APM? I don't think it would be correct to change the CM APM code >> without proper testing. > As I already told this particular patch is not tested. All others are needless to say tested. > I do not have APM setup to test this fix. > I am ok to drop this patch and provide fix when crash occurs later on. I suggest you ask the CM maintainer (Sean) for his opinion on that matter. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
