On 9/6/2017 7:53 PM, Jason Gunthorpe wrote:
On Wed, Sep 06, 2017 at 07:49:03PM +0300, Yishai Hadas wrote:
The commentary was focused on IPoIB as this is the main use case that we
come to solve.
It is more than that, why does mlx5_post_send_underlay refer to
things like MLX5_IPOIB_INLINE_MAX_HEADER_SIZE ? Those constants seem
mis-named.
And then there are comments like this:
/* We expect at least 4 bytes as part of first entry to hold the IPoIB header */
Which really doesn't sound general at all.
The specific IPoIB handling as of copying from the application gather
data into the header is some device limitation to support sending IPoIB
packets. This is not required in the general case but will work as well.
Future devices may work properly without that need, once be ready we may
have some device capability exposed from kernel and clean this specific
handling. Will update commit log to include this information as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
