On Wed, Sep 06, 2017 at 07:49:03PM +0300, Yishai Hadas wrote: > The commentary was focused on IPoIB as this is the main use case that we > come to solve. It is more than that, why does mlx5_post_send_underlay refer to things like MLX5_IPOIB_INLINE_MAX_HEADER_SIZE ? Those constants seem mis-named. And then there are comments like this: > /* We expect at least 4 bytes as part of first entry to hold the IPoIB header */ Which really doesn't sound general at all. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html