On 9/6/2017 7:04 PM, Jason Gunthorpe wrote:
On Wed, Sep 06, 2017 at 05:38:49PM +0300, Yishai Hadas wrote:+ if (unlikely(qp->flags & MLX5_QP_FLAGS_USE_UNDERLAY)) { + err = mlx5_post_send_underlay(qp, wr, &seg, &size, &sg_copy_ptr); + if (unlikely(err)) { + *bad_wr = wr; + goto out; + } + }I don't know anything about your device, but this patch looks to me like it enables for any IBV_QP_CREATE_SOURCE_QPN user
Correct, the code is generic and can work not only with IPoIB packets. - and it seems
to contain a lot of IPoIB specific commentary. It is wrong to assume that all IBV_QP_CREATE_SOURCE_QPN QP's are IPoIB. At a minimum some of the commentary needs revising..
The commentary was focused on IPoIB as this is the main use case that we come to solve.
I'll revise the commit log to better describe the general case and mention the IPoIB as a specific use case, will send V1 for that.
Thanks for comment on. Yishai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
