Re: [PATCH rdma-core 3/3] mlx5: Add support for sending IPoIB packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 06, 2017 at 05:38:49PM +0300, Yishai Hadas wrote:

> +			if (unlikely(qp->flags & MLX5_QP_FLAGS_USE_UNDERLAY)) {
> +				err = mlx5_post_send_underlay(qp, wr, &seg, &size, &sg_copy_ptr);
> +				if (unlikely(err)) {
> +					*bad_wr = wr;
> +					goto out;
> +				}
> +			}

I don't know anything about your device, but this patch looks to me
like it enables for any IBV_QP_CREATE_SOURCE_QPN user - and it seems
to contain a lot of IPoIB specific commentary.

It is wrong to assume that all IBV_QP_CREATE_SOURCE_QPN QP's are IPoIB.

At a minimum some of the commentary needs revising..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux