Re: [rdma-next 01/33] Revert "IB/core: Add flow control to the portmapper netlink calls"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 01, 2017 at 03:20:11PM +0000, Bart Van Assche wrote:
> On Tue, 2017-08-01 at 10:15 -0500, Chien Tin Tung wrote:
> > On Tue, Aug 01, 2017 at 09:22:47AM -0500, Christopher Lameter wrote:
> > > On Tue, 1 Aug 2017, Chien Tin Tung wrote:
> > > 
> > > > Why do I need to explain the original patch?  It was accepted many kernels
> > > > ago.  Your questions on the original were based on false assumptions and
> > > > facts which I've proven over and over.  You are right in that I do
> > > > not want to revisit those either.  There is a patch that can solve
> > > > the problem you are facing but yet you insist on the revert.  This is
> > > > very puzzling to me.  You simply refuse to move this forward.  That
> > > > is your choice but revert is a no go for me.
> > > 
> > > Ok this is pretty confusing to someone not involved in the prior
> > > discussions. Could both of your stop attacking each other and start
> > > talking about the technical issues?
> > 
> > There's been multiple threads over this revert.  This one is the
> > latest Leon walked away from: https://patchwork.kernel.org/patch/9814367/
> > 
> > I'm simply asking for proof/evidence/facts to back up Leon's claims.
> > Show me the code/stack trace/whatever and I will be happy to admit wrong
> > publicly on the list and move on.  I do have better things to do than
> > to NACK a revert.
> 
> Hello Chien,
> 
> What Leon wrote, namely that calls that send netlink data from kernel to user
> space should be non-blocking makes sense to me.

That's been addressed in so many emails I won't rehash.  If _no_one_ should
block (it is actually a one shot retry with a timeout) sending Netlink message
from kernel to user, why don't Leon or you patch that code out?  All of
it, not just ibnl_unicast().

> So please be more constructive than replying with "NAK".

I've sent so many emails (some you were CC'd), so I'm not sure how
much more constructive I can be.  BTW, did you see the one with my
attempt at world peace (https://www.spinics.net/lists/linux-rdma/msg50591.html)?

Here are the relevant threads for people that are interested in participating
in this discussion.

https://patchwork.kernel.org/patch/9814367/

https://patchwork.kernel.org/patch/9752855/

Chien
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux