On Wed, May 10, 2017 at 09:50:05AM -0600, Jason Gunthorpe wrote:
> On Wed, May 10, 2017 at 11:35:47AM +0200, Benjamin Drung wrote:
> > Am Dienstag, den 09.05.2017, 12:05 -0600 schrieb Jason Gunthorpe:
> > > On Tue, May 09, 2017 at 07:43:09PM +0200, Benjamin Drung wrote:
> > >
> > > > * Can we upstream some redhat files, i.e. move them out of the
> > > > redhat
> > > > directory and maintain them in their corresponding code? Following
> > > > files fall in this category:
> > >
> > > Anything in the redhat directory could be moved out if it is going to
> > > be used by another distro. It is there waiting for other distros to
> > > look at it.
> >
> > * The ifdown-ib and ifup-ib scripts are redhat-specific. It won't work
> > with ifupdown from Debian.
> >
> > * The files related to mlx4 look like a special handling for mlx4 to me
> > and they do not following the KISS principle.
>
> One part is managing the need to setup multi-protocol ports on
> boot. This seems like a general requirement for mlx4/5 so maybe it
> should get some more common solution..
>
> > * What's the purpose of the cxgb{3,4} modprobe files?
>
> cxgb is a multi-kernel module driver, those scripts are an attempt to
> load the other parts when the main driver is loaded. I'm not sure why
> cxgb is special enough to get these files but mlx/etc are not.
>
> I suspect it is old cruft because redhat/rdma.kernel-init handles
> things uniformly on systemd environments.
>
> I've been thinking we should patch the kernel to solve this problem
> instead of using this ugly userspace solution.
Can it be related to the fact that mlx5 core calls to
request_module_nowait for mlx5_ib and chelsio doesn't do it?
>
> > Jarod already created a rdma-core package in debian/control in commit
> > 8df5873b9. Currently we do not have a rdma-core package in Debian and
> > no package with a kernel-boot service file. I know that the openibd and
> > mlnx-ofed-kernel-utils packages shipped a openibd service that does
> > similar job.
>
> Yes, pulling something like openibd into rdma-core is the idea here..
>
> > Do we want to call the binary package that contains the kernel-boot
> > service 'rdma-core' or simplify that to 'rdma'? We should use the same
> > binary package name across the distributions (unless it's conflicting
> > with a naming convention).
>
> I think rdma-core is fine..
>
> > Can you come up with a patch set? I will be happy to review it. Note
> > that paths like /usr/libexec/rdma-init-kernel (in rdma.service) needs
> > to be made configurable. In Debian, we would install these helper
> > scripts in /usr/lib/$packagename/$filename.
>
> Maybe Leon's team will try to tackle some of this? It is complicated,
> the RH scripts do quite a bit stuff :\
I would be happy to help, but I'm not sure that I understand what should
be done :(
>
> But this doesn't seem particularly urgent for Debian packaging, right?
>
> Jason
Attachment:
signature.asc
Description: PGP signature
