On Wed, Mar 31, 2021 at 02:51:35PM -0500, Bob Pearson wrote: > Is the long term goal to take clang-format as the default whitespace format? Sort of. clang-format is quite close to the accepted kernel standard and makes maintaince alot easier, but gets a bunch of stuff wrong. > If so should I just reformat all the files in rxe now and get it over with? We try not to do this, just fix egregious errors when you touch the code. There seem to be two camps on this topic: - Internal consistency is more important that following the normative style. This is the idea that if one file is insane it should stay consistently isane. This avoids files looking "hard to read" - New code should follow the normative style. Old code should be changed when it is touched. Files will become internally inconsistent. This avoids everyone doing maintenance work from having to understand a million different local style convections I tend to be in the latter group. Especially when it comes to the annoying vertical alignment that is so common in RDMA. Jason
