On 3/30/21 5:54 PM, Jason Gunthorpe wrote: > On Tue, Mar 30, 2021 at 03:46:24PM -0500, Bob Pearson wrote: >> On 3/30/21 3:12 PM, Jason Gunthorpe wrote: >>> On Thu, Mar 25, 2021 at 04:24:26PM -0500, Bob Pearson wrote: >>>> In the original rxe implementation it was intended to use a common >>>> object to represent MRs and MWs but they are different enough to >>>> separate these into two objects. >>>> >>>> This allows replacing the mem name with mr for MRs which is more >>>> consistent with the style for the other objects and less likely >>>> to be confusing. This is a long patch that mostly changes mem to >>>> mr where it makes sense and adds a new rxe_mw struct. >>>> >>>> Signed-off-by: Bob Pearson <rpearson@xxxxxxx> >>>> Acked-by: Zhu Yanjun <zyjzyj2000@xxxxxxxxx> >>>> v2: >>>> v1 of this patch included some fields in the new rxe_mw struct >>>> which were not yet needed. They are removed in v2. >>>> This patch includes changes needed to address the fact that >>>> the ib_mw struct is now being allocated in rdma/core. >>> >>> Applied to for-next >>> >>> I touched it with clang-format first though, lots of little whitespace >>> issues >>> >>> Thanks, >>> Jason >>> >> Thanks. Is that a stand along app or a git sub-command? > > It is part of clang > > https://clang.llvm.org/docs/ClangFormat.html > > The sequence at the bottom is useful > > git diff -U0 --no-color HEAD^ | clang-format-diff.py -i -p1 > > But I also have it on a current-single-statement-only hotkey in my editor > > Jason > Is the long term goal to take clang-format as the default whitespace format? If so should I just reformat all the files in rxe now and get it over with? Bob
