Re: [PATCH for-next v2] RDMA/rxe: Split MEM into MR and MW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 30, 2021 at 03:46:24PM -0500, Bob Pearson wrote:
> On 3/30/21 3:12 PM, Jason Gunthorpe wrote:
> > On Thu, Mar 25, 2021 at 04:24:26PM -0500, Bob Pearson wrote:
> >> In the original rxe implementation it was intended to use a common
> >> object to represent MRs and MWs but they are different enough to
> >> separate these into two objects.
> >>
> >> This allows replacing the mem name with mr for MRs which is more
> >> consistent with the style for the other objects and less likely
> >> to be confusing. This is a long patch that mostly changes mem to
> >> mr where it makes sense and adds a new rxe_mw struct.
> >>
> >> Signed-off-by: Bob Pearson <rpearson@xxxxxxx>
> >> Acked-by: Zhu Yanjun <zyjzyj2000@xxxxxxxxx>
> >> v2:
> >>  v1 of this patch included some fields in the new rxe_mw struct
> >>  which were not yet needed. They are removed in v2.
> >>  This patch includes changes needed to address the fact that
> >>  the ib_mw struct is now being allocated in rdma/core.
> > 
> > Applied to for-next
> > 
> > I touched it with clang-format first though, lots of little whitespace
> > issues
> > 
> > Thanks,
> > Jason
> > 
> Thanks. Is that a stand along app or a git sub-command?

It is part of clang

https://clang.llvm.org/docs/ClangFormat.html

The sequence at the bottom is useful

git diff -U0 --no-color HEAD^ | clang-format-diff.py -i -p1

But I also have it on a current-single-statement-only hotkey in my editor

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux