Hi! > > Well, having a look on the ACPI spec I'm thinking that what we're trying to do > > with this patch is actually wrong. > > No idea :) > > > Instead, we should rip off all of the invocations of pm_ops->whatever() from > > the hibernation code paths (with the below exceptions) and *if* the platform > > method is to be used, call pm_ops to make the system go down, in the following > > way: > > 1) call pm_ops->prepare(PM_SUSPEND_DISK) > > 2) suspend devices (ie. call device_suspend() etc.) > > 3) call pm_ops->enter(PM_SUSPEND_DISK) > > and if that *fails* (ie. pm_ops->enter() returns): > > 4) call pm_ops->finish(PM_SUSPEND_DISK) > > 5) halt the system > > Can we still split that off to another method so we don't use pm_ops? No > matter how we invoke hibernation_ops or in what order, imho we shouldn't > use pm_ops. Well... the powerdown during hibernation... does not have _anything_ to do with snapshot/restore. It is really a very deep sleep; similar to soft powerdown, but not quite. So this usage of pm_ops seems ok. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
