Hi! > > > However, PM_DISK_PLATFORM and PM_DISK_FIRMWARE sort-of abuse the pm_ops > > > that I have killed to call into arch code... it's all crap as it exposes > > > to all archs some behaviours that may not be supported by those archs. > > > > Feel free to kill PM_DISK_FIRMWARE. PM_DISK_PLATFORM looks like the > > "right way" to do swsusp on acpi-enabled systems, so it should stay... > > No, not in this form. It will be under arch control too. Makes no No problem. What I was trying to say is "feel free to remove functionality of PM_DISK_FIRMWARE". Functionality of PM_DISK_PLATFORM needs to stay. > What I'll do is that I'll keep the "shutdown" case and will rename the > file generic_disk.c. It will be a "drop in" implementation that > architectures can use if they have no callbacks need at all. PPC won't > use it though. And I suspect x86 neither. Sounds good to me. Pavel -- Boycott Kodak -- for their patent abuse against Java.