On Mon, 2005-06-27 at 15:49 +1000, Benjamin Herrenschmidt wrote: > Hi ! > > So I'm still sitting on that rewrite of the pmac suspend code including > suspend to disk consolidation etc... that I would really like to get > upstream. However, I'm still having a problem: > > - I'm still adding all those callbacks to pm_ops, Patrick wants to get > the stuff out of the core, which I agree, but I don't feel like "fixing" > x86 neither :) Pavel wants to keep the existing stuff. I'd like to move it out of the core and use the pm functions as a library. > > - If I keep my callbacks addition, we need to consolidate > kernel/power/disk.c with kernel/power/main.c. I need all callbacks in > both cases. The current inconsistency makes little sense. > > - I want that in 2.6.13 final, so please, let's decide something :) > > Ben. I'm familiar with the ACPI code. If you'd like, I could work on the x86 pm_ops. Let's discuss how we would change the existing PM code... I was thinking each arch could provide a table of system power states with an ->enter() function for each. We would then show the names of these states in "/sys/power/state", and the user could select one. Did you have something else in mind? Thanks, Adam
