On Tue, 2005-06-28 at 06:58 +0200, Pavel Machek wrote: > Hi! > > > However, PM_DISK_PLATFORM and PM_DISK_FIRMWARE sort-of abuse the pm_ops > > that I have killed to call into arch code... it's all crap as it exposes > > to all archs some behaviours that may not be supported by those archs. > > Feel free to kill PM_DISK_FIRMWARE. PM_DISK_PLATFORM looks like the > "right way" to do swsusp on acpi-enabled systems, so it should stay... No, not in this form. It will be under arch control too. Makes no sense to aim to remove the pm_ops callbacks and just add new ones for PM_DISK_FIRMWARE :) Instead, ACPI systems will expose an S4 state that does the right thing and calls swsusp_* library routines to do the job. What I'll do is that I'll keep the "shutdown" case and will rename the file generic_disk.c. It will be a "drop in" implementation that architectures can use if they have no callbacks need at all. PPC won't use it though. And I suspect x86 neither. Ben.
