On Tue, Jan 08, 2019 at 11:58:24AM +0100, Peter Wu wrote: > > Would this patch: > > > > https://patchwork.ozlabs.org/patch/1021317/ > > > > break runtime D3cold for the discrete GPU on Optimus laptops such as > > your Clevo P651RA? Specifically, is the Root Port above the GPU > > marked "(Slot+)" in lspci -vv? (There doesn't seem to be raw lspci > > output in https://github.com/Lekensteyn/acpi-stuff) > > Thanks for bringing this into my attention. There are a couple of full > lspci dumps, for example for the Dell XPS 9560. > https://github.com/Lekensteyn/acpi-stuff/blob/master/d3test/XPS9560/lspci-bare-metal.txt > This has upstream port 00:01.0 attached to GPU 01:00.0 > > 00:01.0 PCI bridge [0604]: Intel Corporation Xeon E3-1200 v5/E3-1500 v5/6th Gen Core Processor PCIe Controller (x16) [8086:1901] (rev 05) (prog-if 00 [Normal decode]) > ... > Capabilities: [a0] Express (v2) Root Port (Slot+), MSI 00 > > and would indeed be negatively affected by this patch. I can observe the > same for the Clevo P651RA (for which I can also send the full lspci dump > if you need). Thanks both. I guess that leaves us the blacklist. I can re-send it rebased on top of v5.0-rc1 if there are no objections.