Hi,
On Tuesday 03 April 2018 06:50 PM, Gustavo Pimentel wrote:
> Hi Kishon,
>
> On 03/04/2018 11:55, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Tuesday 03 April 2018 04:13 PM, Gustavo Pimentel wrote:
>>> Hi Kishon,
>>>
>>> On 02/04/2018 06:35, Kishon Vijay Abraham I wrote:
>>>>
>>>>
>>>> On Wednesday 28 March 2018 05:08 PM, Gustavo Pimentel wrote:
>>>>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
>>>>
>>>> Please add a commit message.
>>>
>>> Ok. I'll add. Thanks for noticing it.
>>>
>>>>> ---
>>>>> Documentation/devicetree/bindings/pci/designware-pcie.txt | 13 +++++++++++++
>>>>> 1 file changed, 13 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>>>>> index 6300762..4bb2e08 100644
>>>>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
>>>>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>>>>> @@ -3,6 +3,7 @@
>>>>> Required properties:
>>>>> - compatible:
>>>>> "snps,dw-pcie" for RC mode;
>>>>> + "snps,dw-pcie-ep" for EP mode;
>>>>> - reg: Should contain the configuration address space.
>>>>> - reg-names: Must be "config" for the PCIe configuration space.
>>>>> (The old way of getting the configuration address space from "ranges"
>>>>> @@ -56,3 +57,15 @@ Example configuration:
>>>>> #interrupt-cells = <1>;
>>>>> num-lanes = <1>;
>>>>> };
>>>>> +or
>>>>> + pcie_ep: pcie_ep@dfc00000 {
>>>>> + compatible = "snps,dw-pcie-ep";
>>>>> + reg = <0xdfc00000 0x0001000>, /* IP registers 1 */
>>>>> + <0xdfc01000 0x0001000>, /* IP registers 2 */
>>>>
>>>> Doesn't this have iATU unroll space?
>>>
>>> I don't think EP has it, but I'm no expert on this matter. Can you provide me
>>> some example of having iATU unroll space mapping would be useful in EP scope?
>>
>> I'm not sure. I thought if the dwc3 core version is 4.80, then it'll have a
>> separate ATU space irrespective of RC mode or EP mode.
>
> As replied on patch 1, let's leave out any reference of iATU unroll to avoid
> any confusion. Agree?
Mentioning iATU is fine as long as you change the size field in the "reg" property.
Thanks
Kishon
