Hi, We detected that the selection of "PCI resource re-allocation detection" (CONFIG_PCI_REALLOC_ENABLE_AUTO) is ignored in some situations. This can happen as the related functionality (drivers/pci/setup-bus.c, lines 1702 - 1738) depends on CONFIG_PCI_REALLOC_ENABLE_AUTO and CONFIG_PCI_IOV, while in Kconfig (drivers/pci/Kconfig, lines 42 - 53) this functionality is only controlled by CONFIG_PCI_REALLOC_ENABLE_AUTO. The dependency on CONFIG_PCI_IOV is only mentioned in the comment of CONFIG_PCI_REALLOC_ENABLE_AUTO, but not checked by Kconfig. As CONFIG_PCI_IOV is selected by many other configuration options, we expect the failure to happen in very few configurations only, which makes it even harder to detect and fix. However, there exist configurations that will still be faulty. The suggested fix ensures that the re-allocation is always working as specified through an automated selection of CONFIG_PCI_IOV if CONFIG_PCI_REALLOC_ENABLE_AUTO is selected. Best regards, Sascha -- ----------------------------------------------------------------------- Sascha El-Sharkawy, MSc University of Hildesheim Tel.: +49 (0) 5121 / 883-40336 Institute of Computer Science Fax: +49 (0) 5121 / 883-40337 Universitaetsplatz 1 elscha@xxxxxxxxxxxxxxxxxxxxx D-31141 Hildesheim, Germany http://www.sse.uni-hildesheim.de
Attachment:
PCI_REALLOC_ENABLE_AUTO.patch.gz
Description: PCI_REALLOC_ENABLE_AUTO.patch.gz
