Re: [PATCH] PCI SUBSYSTEM allows inconsistent configuration, current Kernel version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sascha,

On Wed, Aug 23, 2017 at 08:22:38AM +0200, Sascha El-Sharkawy wrote:
> We detected that the selection of "PCI resource re-allocation detection"
> (CONFIG_PCI_REALLOC_ENABLE_AUTO) is ignored in some situations. This can
> happen as the related functionality (drivers/pci/setup-bus.c, lines 1702
> - 1738) depends on CONFIG_PCI_REALLOC_ENABLE_AUTO and CONFIG_PCI_IOV,
> while in Kconfig (drivers/pci/Kconfig, lines 42 - 53) this functionality
> is only controlled by CONFIG_PCI_REALLOC_ENABLE_AUTO.
> 
> The dependency on CONFIG_PCI_IOV is only mentioned in the comment of
> CONFIG_PCI_REALLOC_ENABLE_AUTO, but not checked by Kconfig. As
> CONFIG_PCI_IOV is selected by many other configuration options, we expect
> the failure to happen in very few configurations only, which makes it
> even harder to detect and fix. However, there exist configurations that
> will still be faulty.  The suggested fix ensures that the re-allocation
> is always working as specified through an automated selection of
> CONFIG_PCI_IOV if CONFIG_PCI_REALLOC_ENABLE_AUTO is selected.

I'm sorry that I missed this patch.  I normally work from patchwork
(https://patchwork.ozlabs.org/project/linux-pci/list/), and it apparently
doesn't pick up patches that are attached (or maybe it just misses gzipped
ones).

Can you please repost this as plain-text email with the patch included
inline, with a changelog and Signed-off-by?  Then patchwork should pick it
up and I won't forget about it.

For details about Signed-off-by, etc, see
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst

Bjorn



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux