On Fri, Oct 31, 2008 at 05:41:00PM +1100, Michael Ellerman wrote: > On Fri, 2008-10-31 at 14:48 +1100, Vincent Rizza wrote: > > Michael raised the issue of dev->stop() calling pci_disable_msi() > > on ifconfig down. The rtnl_lock eliminates that problem. > > I did, but that's only one example of something that can call > pci_disable_msi(). It needs to be robust against anything that might > call it, eg. a hotplug disk controller or something. > > So I think using list_for_each_entry_safe() is the right option, using > rtnl_lock() definitely isn't. Um, list_for_each_entry_safe() is only safe against _you_ deleting entries, not against _other people_ deleting entries. You'd want to switch over to RCU for this. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
