Re: [RFC][PATCH] Add sysfs entry that displays MSI-X IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-10-31 at 09:25 +1100, Vincent Rizza wrote:
> Here are the changes as requested.
> 
>  
> +#ifdef CONFIG_PCI_MSI
> +static ssize_t msix_show(struct device *dev,
> +			 struct device_attribute *attr, char *buf)
> +{
> +	struct pci_dev *pdev = to_pci_dev(dev);
> +	struct msi_desc *entry, *next;
> +	u32 total = 0;
> +
> +	list_for_each_entry_safe(entry, next, &pdev->msi_list, list) {
> +		total += sprintf(buf + total, "%u\n", entry->irq);
> +	}
> +
> +	return total;
> +}
> +#endif

Looks good, fwiw:

Acked-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>

Do you have a network adapter that does MSI-X? I don't. It'd be
reassuring to run a loop of 'ifconfig up; ifconfig down', and in
parallel dump this file - just to try and exercise the race condition a
bit.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux