On Wed, 2008-10-29 at 15:00 +1100, Vincent Rizza wrote: > Michael Ellerman wrote: > > Is there anything to stop this being called while we're deleting entries > > from the list in msi_free_irqs() ? > > Technically there isn't. Some routines that call msi_free_irqs(), > pci_disable_msix() for example, are global so that could mess things up. > However in reality these will only be called on driver probe and remove > which are called before sysfs creation and after sysfs deletion > respectively. So it won't be an issue in the normal case. I don't think that's true. Some network drivers call pci_disable_msi() from dev->stop(), which you can trigger easily with "ifconfig down" AFAIK. > Theoretically there could be an issue, should we put it in a spinlock? I think using list_for_each_entry_safe() is good enough. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
