Michael Ellerman wrote:
On Wed, 2008-10-29 at 15:00 +1100, Vincent Rizza wrote:
Michael Ellerman wrote:
Is there anything to stop this being called while we're deleting entries
from the list in msi_free_irqs() ?
Technically there isn't. Some routines that call msi_free_irqs(),
pci_disable_msix() for example, are global so that could mess things up.
However in reality these will only be called on driver probe and remove
which are called before sysfs creation and after sysfs deletion
respectively. So it won't be an issue in the normal case.
I don't think that's true. Some network drivers call pci_disable_msi()
from dev->stop(), which you can trigger easily with "ifconfig down"
AFAIK.
Ok thanks I wasn't aware of that.
Theoretically there could be an issue, should we put it in a spinlock?
I think using list_for_each_entry_safe() is good enough.
This has me a little confused if my understanding of the macro is correct.
Thanks,
-- Vinnie.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
