On Thu, 2008-10-30 at 18:08 +0900, Kenji Kaneshige wrote: > Andrew Patterson wrote: > > This is v2 of the "call _OSC support during root bridge discovery" > > patchset. At Bjorn Helgaas's suggestion, I have merged all the MSI > > handling patches into one patch. Kenji Kaneshige also noted that I was > > not checking aspm_disabled before setting ASPM _OSC capabilities. This > > has been fixed. > > > > Kenji also noted that the pci_msi_enable can be changed in various > > quirks after root bridge discovery, resulting in the incorrect setting > > of the MSI _OSC capability. I do not yet have a solution for this problem. > > > > Unfortunately, I don't have good idea about it yet too. In addition, > I don't understand how to handle the case if a feature is supported > but disabled by OS, from the PCI firmware spec. > If we should not set _OSC capabilities when it is supported but > disabled by OS, maybe we need also consider what we should do for > OSC_EXT_PCI_CONFIG_SUPPORT and OSC_PCI_SEGMENT_GROUPS_SUPPORT > if mmconfig is disabled, as well as aspm_disabled and pci_msi_enable. > A good idea. I try and come up with something. > By the way, Taku Izumi plan to post some patches to reduce _OSC > evaluation for _OSC control soon. I'm appreciate it if you will try > it on your big server. > I would be happy to help. Getting time on this server is sometimes difficult, so it may take a while before I can run a test. Andrew > Thanks, > Kenji Kaneshige > > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html