Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2013 14:02, Javier Martinez Canillas wrote:
On 10/07/2013 01:58 PM, Benoit Cousson wrote:
Hi Javier,

On 07/10/2013 13:54, Javier Martinez Canillas wrote:
On 10/07/2013 12:43 PM, Roger Quadros wrote:
Javier,

On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote:
Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards")
added USB OTG support for most OMAP boards but some OMAP3 boards
such as the IGEPv2 were not updated. This patch adds an USB OTG
device node to this board.

Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
---
   arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++
   1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index eedf0d8..903e944 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -166,3 +166,10 @@
   		smsc,save-mac-address;
   	};
   };
+
+&usb_otg_hs {
+	interface-type = <0>;
+	usb-phy = <&usb2_phy>;

With the PHY generic framework in Greg's usb-next branch [1], you will also need to add

+       phys = <&usb2_phy>;
+       phy-names = "usb2-phy";

+	mode = <3>;
+	power = <50>;
+};


So it would be good to test with the usb-next branch.

cheers,
-roger

[1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git


Hi Roger,

Thanks for the pointer, I'll add those properties and test using the PHY generic
framework.

Should I expect a v3 then?


Hi Benoit,

Yes, I'll test it and send a v3 in the next few hours, sorry for not being clear
about that.


That's OK, I was applying your series when I saw your email ;-)

I'm waiting for the next one.

Thanks,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux