Hi Shweta, "Gulati, Shweta" <shweta.gulati@xxxxxx> writes: [...] >>> >>> And what about vdd_name? It should probably be removed as well. >>> >> >> Yes, but it's currently used by the SR layer (currently the only user.) >> >> Removing it required cleaning up the SR layer as well, so I decided to >> leave the SR cleanups for someone else for the moment while I focus on >> the voltage layer(s) >> > Even if we try to remove 'vdd_name', how should we get 'struct voltagedomain' > info corresponding to sr_mpu, sr_core in sr_dev_init API? > > As functional clock of SR1 and SR2 are from wake up domain, so even if > we try to use current Clockdomain and Powerdomain framework APIs, to > get 'clkdomain' pointer and then retrieve 'pwrdomain' pointer, finally > getting 'voltdomain' pointer we would get 'WKUP' voltage domain ptr > not the 'mpu' or 'core' voltdomain pointer. Correct. I got this far and realized not only does the voltage layer need a cleanup, the SR layer needs a cleanup, but I need to focus on one thing at a time. As you noticed, what we need is the voltage domain of the SR sensor, not the voltage domain of the SR IP. Probably the best way to do this is ad the sensor voltage domain to the dev_attr of each SR module. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
