Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes: >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman >> Sent: Thursday, March 24, 2011 5:30 AM >> To: linux-omap@xxxxxxxxxxxxxxx >> Cc: Paul Walmsely; Benoit Cousson >> Subject: [PATCH/RFC 07/19] OMAP3: voltage: add scalable flag to >> voltagedomain >> >> Add a 'bool scalable' flag to the struct powerdomain and set it for > > I suppose you meant "struct voltagedomain". yes > But shouldn't this flag be part of PMIC struct? > Voltage scalability depends on the kind of VDD supply from PMIC. So even > if OMAP supports voltage scaling, we may not be able to scale the voltage > if PMIC does not support it. That's a good point. Probably I can drop this flag and just use the existence of the various fields of the voltage domain (pmic, vc, vp, etc.) to determine if the voltdm can scale. Kevin >> the MPU_IVA and CORE voltage domains. > >> >> Signed-off-by: Kevin Hilman <khilman@xxxxxx> >> --- >> arch/arm/mach-omap2/voltage.c | 3 +++ >> arch/arm/mach-omap2/voltage.h | 2 ++ >> arch/arm/mach-omap2/voltagedomains3xxx_data.c | 2 ++ >> 3 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach- >> omap2/voltage.c >> index f995003..bc944ff 100644 >> --- a/arch/arm/mach-omap2/voltage.c >> +++ b/arch/arm/mach-omap2/voltage.c >> @@ -1054,6 +1054,9 @@ int __init omap_voltage_late_init(void) >> pr_err("%s: Unable to create voltage debugfs main dir\n", >> __func__); >> list_for_each_entry(voltdm, &voltdm_list, node) { >> + if (!voltdm->scalable) >> + continue; >> + >> if (voltdm->vdd) { >> if (omap_vdd_data_configure(voltdm)) >> continue; >> diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach- >> omap2/voltage.h >> index 5440298..25cfb5c 100644 >> --- a/arch/arm/mach-omap2/voltage.h >> +++ b/arch/arm/mach-omap2/voltage.h >> @@ -53,11 +53,13 @@ struct omap_vfsm_instance_data { >> /** >> * struct voltagedomain - omap voltage domain global structure. >> * @name: Name of the voltage domain which can be used as a unique >> identifier. >> + * @scalable: Whether or not this voltage domain is scalable >> * @node: list_head linking all voltage domains >> * @vdd: to be removed >> */ >> struct voltagedomain { >> char *name; >> + bool scalable; >> struct list_head node; >> struct omap_vdd_info *vdd; >> }; >> diff --git a/arch/arm/mach-omap2/voltagedomains3xxx_data.c >> b/arch/arm/mach-omap2/voltagedomains3xxx_data.c >> index b476ee6..e9664843 100644 >> --- a/arch/arm/mach-omap2/voltagedomains3xxx_data.c >> +++ b/arch/arm/mach-omap2/voltagedomains3xxx_data.c >> @@ -61,11 +61,13 @@ static struct omap_vdd_info omap3_vdd2_info = >> { >> >> static struct voltagedomain omap3_voltdm_mpu = { >> .name = "mpu_iva", >> + .scalable = true, >> .vdd = &omap3_vdd1_info, >> }; >> >> static struct voltagedomain omap3_voltdm_core = { >> .name = "core", >> + .scalable = true, >> .vdd = &omap3_vdd2_info, >> }; > Why is this applicable only for OMAP3 and not for OMAP4? > > Vishwa >> >> -- >> 1.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
