Re: [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kevin,

On 3/19/2011 1:18 AM, Hilman, Kevin wrote:
The voltage domain pointer currently in struct omap_hwmod is not used
and does not belong here.  Instead, voltage domains will be associated
with powerdomains in forthcoming patches.

Technically speaking, an IP, and thus the hwmod does belong to a voltage domain, a power domain and a clock domain.

What is maybe important to add is that since clkdm < pwrdm < voltdm, we can potentially avoid providing the information for the each domain type.

At some point the hwmod will have to contain a clkdm instead of relying on the main_clk to get it... but that's another topic...

Signed-off-by: Kevin Hilman<khilman@xxxxxx>
---
  arch/arm/plat-omap/include/plat/omap_hwmod.h |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h b/arch/arm/plat-omap/include/plat/omap_hwmod.h
index 1adea9c..a5fa7c1 100644
--- a/arch/arm/plat-omap/include/plat/omap_hwmod.h
+++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h
@@ -520,7 +520,6 @@ struct omap_hwmod {
  	struct clk			*_clk;
  	struct omap_hwmod_opt_clk	*opt_clks;
  	char				*vdd_name;

And what about vdd_name? It should probably be removed as well.

Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux