On Tue, Mar 15, 2011 at 20:03, Vishwanath BS <vishwanath.bs@xxxxxx> wrote:
> This patch adds board specific parameters for ZOOM3 and OMAP4430 SDP Boards.
> The same needs to be done for other OMAP3 and OMAP4 boards once the approach
> is accepted.
Would have been great to see this info in 0/0 - what happens without
these changes on other boards?
[...]
> +union omap_volt_board_data zoom_mpu_volt_data = {
> + .omap3_board_data = {
> + .vdd_setup_ret = {
> + .voltsetup = OMAP3_VOLTSETUP_VDD1_RET,
I disagree this is a board specific param - the help says "setup time
of the VDDregulators in us" - seems to me that it is PMIC information
> + .clksetup = OMAP3_CLKSETUP_RET,
????? why cant i just give oscillator ramp time in uSec?
> + .voltsetup2 = 0,
why should I as a board developer give this as well, why cant voltage
layer do addition and save me a param?
> + },
> +
> + .vdd_setup_off = {
> + .voltsetup = OMAP3_VOLTSETUP_VDD1_OFF,
> + .clksetup = OMAP3_CLKSETUP_OFF,
> + .voltsetup2 = OMAP3_VOLTSETUP2,
> + },
> + .voltoffset = OMAP3_VOLTOFFSET_OFF
"offset-time to de-assert sys_offmode when exiting the OFF mode" - how
am I supposed to measure that? again - why cant voltage layer add
numbers?
> + }
> +};
> +
my overall suggestion - when I fill in board file params - I should say:
I use PMIC x, i have oscillator with ramp "y" uSec - the params should
talk my language as a board developers - I dont want to know indepth
details of voltage VP/VC registers and what they should contain. it is
upto voltage layer to translate, add, bit shift or do what ever is
necessary to take my board and pmic level details to register details.
Sorry, even though this is a good start for abstraction, the overall
motivation is missed, I think we need to work on it more.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
