RE: [RFC][PATCH 0/3] OMAP PM: Voltage layer clean up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Menon, Nishanth [mailto:nm@xxxxxx]
> Sent: Tuesday, March 15, 2011 8:38 PM
> To: Vishwanath BS
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [RFC][PATCH 0/3] OMAP PM: Voltage layer clean up
>
> On Tue, Mar 15, 2011 at 20:03, Vishwanath BS
> <vishwanath.bs@xxxxxx> wrote:
> >
> > This patch series attempts to do some more clean up on OMAP Voltage
> layer on top
> > of the clean up done by Paul as part of
> > https://patchwork.kernel.org/patch/591421/
> >
> > These patches are generated against latest omap-for-linus branch on
> Tony's tree
> > (commit id: 05f689400ea5fa3d71af82f910c8b140f87ad1f3) and tested
> on OMAP ZOOM3
> > and OMAP4430 SDP with Smartreflex enabled.
> >
> > Vishwanath BS (3):
> >  OMAP PM: Seggregate Voltage layer parameters
> >  OMAP PM: Add support for bypassing VP/VC in Voltage layer
> >  OMAP PM: Add Board specific parameters for OMAP Volatge layer
>
> I dont really see why I need to keep fixing your $subjects, but here
> again,
> all $subjects, OMAP3+: PM: makes more sense
This is not OMAP3 specific. It applies to OMAP4 as well.

>
> >  OMAP PM: Seggregate Voltage layer parameters
>                        ^^^^^^^ spell check please (tip: in vim, use
> ":help spell" to see how to use it while committing itself)
Thanks.
> >  OMAP PM: Add support for bypassing VP/VC in Voltage layer
> >  OMAP PM: Add Board specific parameters for OMAP Volatge layer
>
>          ^^^^^^^^^ spell check voltage and I think you should be using
> small letters for board and voltage
>
> >
> >  arch/arm/mach-omap2/board-4430sdp.c           |   52 +++++++
>
> Curious if Panda and other OMAP3 platforms where considered.
That's TODO as per my Patch3 commit log.

Vishwa
>
> >  arch/arm/mach-omap2/board-zoom.c              |   79
> +++++++++++
> >  arch/arm/mach-omap2/omap_opp_data.h           |    8 +
> >  arch/arm/mach-omap2/omap_twl.c                |  113 ++++++++----
> ----
> >  arch/arm/mach-omap2/opp3xxx_data.c            |   50 +++++++
> >  arch/arm/mach-omap2/opp4xxx_data.c            |   38 +++++
> >  arch/arm/mach-omap2/voltage.c                 |  179
> ++++++++++++++++++++-----
> >  arch/arm/mach-omap2/voltage.h                 |  119
> +++++++++++++++--
> >  arch/arm/mach-omap2/voltagedomains3xxx_data.c |    4 +
> >  arch/arm/mach-omap2/voltagedomains44xx_data.c |    4 +
> >  10 files changed, 541 insertions(+), 105 deletions(-)
> >
>
>
> Regards,
> Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux