> -----Original Message-----
> From: Varadarajan, Charulatha
> Sent: Monday, November 22, 2010 11:32 AM
> To: DebBarma, Tarun Kanti
> Cc: linux-omap@xxxxxxxxxxxxxxx; Cousson, Benoit
> Subject: Re: [PATCHv4 6/14] OMAP4: dmtimer: add hwmod database
>
> These comments are from other hwmod reviews.
>
> On Sat, Nov 20, 2010 at 08:09, Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> wrote:
> > From: Cousson, Benoit <b-cousson@xxxxxx>
>
> Subject should be something like: ( See [1] )
> OMAP4: hwmod data: add dmtimer
>
> Same is applicable to other hwmod DB patches for OMAP2420, OMAP2430
> & OMAP3 to add dmtimer data
Ok.
>
> >
> > Add hwmod database for OMAP4.
> >
> > Signed-off-by: Cousson, Benoit <b-cousson@xxxxxx>
> > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 622
> ++++++++++++++++++++++++++++
>
> <<snip>>
>
> > + .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> > +};
> > +
> > +/*
> > * 'wd_timer' class
> > * 32-bit watchdog upward counter that generates a pulse on the reset
> pin on
> > * overflow condition
> > @@ -1068,6 +1678,18 @@ static __initdata struct omap_hwmod
> *omap44xx_hwmods[] = {
> >
> > /* mpu class */
> > &omap44xx_mpu_hwmod,
> > + /* timer class */
> > + &omap44xx_timer1_hwmod,
> > + &omap44xx_timer2_hwmod,
> > + &omap44xx_timer3_hwmod,
> > + &omap44xx_timer4_hwmod,
> > + &omap44xx_timer5_hwmod,
> > + &omap44xx_timer6_hwmod,
> > + &omap44xx_timer7_hwmod,
> > + &omap44xx_timer8_hwmod,
> > + &omap44xx_timer9_hwmod,
> > + &omap44xx_timer10_hwmod,
> > + &omap44xx_timer11_hwmod,
>
> Add a blank line between each class. See [2]
> Same is applicable to other hwmod DB patches for OMAP2420, OMAP2430
> & OMAP3 to add dmtimer data
Hmm... this is really funny! In fact in earlier patches I gave a blank line.
This time I saw other implementations which does not have blank lines like these and thought that I should remove the blank line:
/* dmm class */
&omap44xx_dmm_hwmod,
/* emif_fw class */
&omap44xx_emif_fw_hwmod,
/* l3 class */
&omap44xx_l3_instr_hwmod,
&omap44xx_l3_main_1_hwmod,
&omap44xx_l3_main_2_hwmod,
&omap44xx_l3_main_3_hwmod,
/* l4 class */
&omap44xx_l4_abe_hwmod,
&omap44xx_l4_cfg_hwmod,
&omap44xx_l4_per_hwmod,
&omap44xx_l4_wkup_hwmod,
Well, I can add blank lines with the hope that someone does not ask me to remove them again ;)
--
Tarun
>
> [1] https://patchwork.kernel.org/patch/282472/
> [2] https://patchwork.kernel.org/patch/308422/
>
> > /* wd_timer class */
> > &omap44xx_wd_timer2_hwmod,
> > &omap44xx_wd_timer3_hwmod,
> > --
> > 1.6.0.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
