These comments are from other hwmod reviews.
On Sat, Nov 20, 2010 at 08:09, Tarun Kanti DebBarma <tarun.kanti@xxxxxx> wrote:
> From: Cousson, Benoit <b-cousson@xxxxxx>
Subject should be something like: ( See [1] )
OMAP4: hwmod data: add dmtimer
Same is applicable to other hwmod DB patches for OMAP2420, OMAP2430
& OMAP3 to add dmtimer data
>
> Add hwmod database for OMAP4.
>
> Signed-off-by: Cousson, Benoit <b-cousson@xxxxxx>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> ---
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 622 ++++++++++++++++++++++++++++
<<snip>>
> + .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> +};
> +
> +/*
> * 'wd_timer' class
> * 32-bit watchdog upward counter that generates a pulse on the reset pin on
> * overflow condition
> @@ -1068,6 +1678,18 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
>
> /* mpu class */
> &omap44xx_mpu_hwmod,
> + /* timer class */
> + &omap44xx_timer1_hwmod,
> + &omap44xx_timer2_hwmod,
> + &omap44xx_timer3_hwmod,
> + &omap44xx_timer4_hwmod,
> + &omap44xx_timer5_hwmod,
> + &omap44xx_timer6_hwmod,
> + &omap44xx_timer7_hwmod,
> + &omap44xx_timer8_hwmod,
> + &omap44xx_timer9_hwmod,
> + &omap44xx_timer10_hwmod,
> + &omap44xx_timer11_hwmod,
Add a blank line between each class. See [2]
Same is applicable to other hwmod DB patches for OMAP2420, OMAP2430
& OMAP3 to add dmtimer data
[1] https://patchwork.kernel.org/patch/282472/
[2] https://patchwork.kernel.org/patch/308422/
> /* wd_timer class */
> &omap44xx_wd_timer2_hwmod,
> &omap44xx_wd_timer3_hwmod,
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
