Hi Thomas, > -----Original Message----- > From: Thomas Petazzoni [mailto:thomas.petazzoni@xxxxxxxxxxxxxxxxxx] > Sent: Tuesday, November 16, 2010 9:41 PM > To: Rajendra Nayak > Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; b-cousson@xxxxxx; khilman@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/6] OMAP: powerdomain: Infrastructure to put arch specific code > > On Tue, 16 Nov 2010 21:08:02 +0530 > Rajendra Nayak <rnayak@xxxxxx> wrote: > > > +struct pwrdm_functions { > > + int (*pwrdm_set_next_pwrst)(struct powerdomain *pwrdm, u8 pwrst); > > + int (*pwrdm_read_next_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_read_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_read_prev_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_set_logic_retst)(struct powerdomain *pwrdm, u8 pwrst); > > + int (*pwrdm_set_mem_onst)(struct powerdomain *pwrdm, u8 bank, u8 pwrst); > > + int (*pwrdm_set_mem_retst)(struct powerdomain *pwrdm, u8 bank, u8 pwrst); > > + int (*pwrdm_read_logic_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_read_prev_logic_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_read_logic_retst)(struct powerdomain *pwrdm); > > + int (*pwrdm_read_mem_pwrst)(struct powerdomain *pwrdm, u8 bank); > > + int (*pwrdm_read_prev_mem_pwrst)(struct powerdomain *pwrdm, u8 bank); > > + int (*pwrdm_read_mem_retst)(struct powerdomain *pwrdm, u8 bank); > > + int (*pwrdm_clear_all_prev_pwrst)(struct powerdomain *pwrdm); > > + int (*pwrdm_enable_hdwr_sar)(struct powerdomain *pwrdm); > > + int (*pwrdm_disable_hdwr_sar)(struct powerdomain *pwrdm); > > + int (*pwrdm_set_lowpwrstchange)(struct powerdomain *pwrdm); > > + int (*pwrdm_wait_transition)(struct powerdomain *pwrdm); > > +}; > > It would probably be great to have some short documentation on this > structure, to detail what are the different operations, what they > should do, etc. Sure, I can add some kerneldoc style headers to the structure to better understand what these functions should do on each OMAP. > > By the way, would pwrdm_operations be more linux-ish than > pwrdm_functions ? I agree. I'll do this as well before I post a V2. Thanks for the review. Regards, Rajendra > > Thanks, > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
