On Mon, May 24, 2010 at 09:07:37AM +0200, ext Gupta, Ajay Kumar wrote:
Hi,
Here is a compile-tested patch since I haven't seen this fixed in mainline
yet. It applies to the tip of Linus' tree.
Attempting to remove usb_nop_xceiv_register() completely will require
someone
with more knowledge of davinci and blackfin archs to comment on what
boards
need the platform_device defined.
NAK..
This is an incorrect fix as it duplicates the code snippet which
is already present in nop file.
I don't believe you understood the purpose of the original patch:
The idea is that currently, it's impossible to build a board which uses
nop transceiver and have that be a module because when you'll have an
undefined function being used on a board file.
Removing the call to nop_xceiv_register() and using a
platform_device_register() is the way to go, since it's only 4 ~ 5 lines
of code anyway.
ps: you really think that adding more and more ifdefs is better than
Amit's patch ??
--
balbi
DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
