Felipe, > > Small suggestion...if we are re-organizing can we make it look similar > to how iommu is structured? This way we can maintain consistency. > > I thought I did. What exactly do you have in mind? 1. What Tony mentioned in another email about using #ifdefs for the platforms. That will be bring close to what is in omap-iommu.c 2. Compare iommu_get with mailbox_get. iommu_get uses driver_find_device to get the iommu structure. I guess we can apply the same logic to get mailbox structure. This way we can get rid of omap_mbox_register, omap_mbox_unregister, and find_mboxes functions. > Also, I noticed that since you made omap3-iommu not omap3-specific, > perhaps it makes sense to remove the omap prefix and just name it > 'iommu'. > -- You are right. It doesn't make sense to add omap prefix any more. Thank you, Best regards, Hari > -----Original Message----- > From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] > Sent: Monday, May 03, 2010 10:09 AM > To: Kanigeri, Hari > Cc: linux-omap; Tony Lindgren; Hiroshi Doyu; Ohad Ben-Cohen > Subject: Re: [RFC/PATCH 6/8] omap: mailbox: more more stuff to > omap2_mbox_init > > On Mon, May 3, 2010 at 4:42 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote: > > Small suggestion...if we are re-organizing can we make it look similar > to how iommu is structured? This way we can maintain consistency. > > I thought I did. What exactly do you have in mind? > > Also, I noticed that since you made omap3-iommu not omap3-specific, > perhaps it makes sense to remove the omap prefix and just name it > 'iommu'. > > Cheers. > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
