From: "ext Kanigeri, Hari" <h-kanigeri2@xxxxxx> Subject: RE: [RFC/PATCH 6/8] omap: mailbox: more more stuff to omap2_mbox_init Date: Mon, 3 May 2010 20:50:39 +0200 > Felipe, > >> > Small suggestion...if we are re-organizing can we make it look similar >> to how iommu is structured? This way we can maintain consistency. >> >> I thought I did. What exactly do you have in mind? > > 1. What Tony mentioned in another email about using #ifdefs for the platforms. That will be bring close to what is in omap-iommu.c > > 2. Compare iommu_get with mailbox_get. iommu_get uses > driver_find_device to get the iommu structure. I guess we can apply > the same logic to get mailbox structure. This way we can get rid of > omap_mbox_register, omap_mbox_unregister, and find_mboxes functions. Right. The same logic could be applied. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
