Re: [PATCH] OMAP3: SDRC: Comment out SDRC AC timing and MR changes in CORE DVFS SRAM code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Olof, Nishanth,

thanks for the comments,

On Wed, 2 Dec 2009, Olof Johansson wrote:

> On Wed, Dec 02, 2009 at 08:12:34AM +0200, Menon, Nishanth wrote:
> 
> > why not make this a #ifdef instead if we need it some other time, a #if
> > 0 and it's intention might not be readable without doing a git annotate
> > in a few months time..
> 
> Just remove the code. The old implementation is still there in git and
> can be brought back if need be. It's the purpose of having revision
> control in the first place.

I'm leaning towards Nishanth's suggestion and making it a Kconfig option. 
That way, users who know that other system initiators will be inactive at 
CORE DVFS time will be able to use optimal SDRC timings in CORE DVFS.

The other issue with removing it completely is that I'm holding out the 
(admittedly slim) hope that someone else will be enticed into helping out 
with this issue, and so I'd reason that since very few people will look at 
older revisions, removing it will drastically reduce the chances that 
others will help.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux