* Pali Rohár <pali.rohar@xxxxxxxxx> [160208 01:14]: > On Friday 29 January 2016 08:20:26 Tony Lindgren wrote: > > Hi, > > > > * Pali Rohár <pali.rohar@xxxxxxxxx> [160129 00:32]: > > > But I do not like this solution as it duplicate omap hsmmc DT > > > specification from nokia n900 DTS file to board pdata-quirks file. > > > > > > It means that in nokia n900 DTS file will be mmc information which will > > > not be used and this is not correct in the way how we use DTS files. > > > > I think you're misunderstanding the above a bit here.. We can pass > > both dts data and auxilary platform_data to the driver. So only > > need to pass the slot names in the aux data set in pdata-quirks.c > > based on the mmc device IO address. > > That would means to change omap hsmmc driver a bit more... I do not it > could be simple... I think all it takes is just copying over the slot names from pdev->dev.platform_data in of_get_hsmmc_pdata()? Looks like you need to use container_of() there to get the pdev, or change it to pass pdev to of_get_hsmmc_pdata() though. > > > I know, but how many users and developers are looking into git *history* > > > if they need to know what is missing in *current* kernel? > > > > > > I think that removing board-rx51.c file would mean that table is lost > > > and everybody forget that this table needs to be ported to nokia n900 > > > DTS file. > > > > How about send a patch to copy those comments to board-n900.dts > > too? > > Ok, I'm fine with it. But I would like to see cpuidle omap support in DT. Hmm but we're already using arch/arm/mach-omap2/cpuidle34xx.c to hit deeper idle states for DT based booting too? Or maybe you mean something else? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
