Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 28 January 2016 08:17:24 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@xxxxxxxxx> [160128 00:34]:
> > On Thursday 28 January 2016 01:05:53 Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > On Thu, Jan 21, 2016 at 02:02:55PM -0800, Tony Lindgren wrote:
> > > > * Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx> [151224 11:02]:
> > > > > Could you elaborate on that patch system? Where it is and do I
> > > > > need some special account/access?
> > > > 
> > > > Sorry going through my pending mail and only now noticed this
> > > > one. Looks like you got it figured out though as the patches
> > > > are in mainline now :)
> > > 
> > > IIRC this was the last blocker for removing n900 legacy code?
> > 
> > No! I know at least two missing-feature regressions in DT booted kernel:
> > 
> > * slot name in sysfs for omap mmc devices
> 
> Can't you do this already by passing platform_data in addition to
> dts using pdata-quirks.c?

After patching omap hsmmc driver it could be possible.

But I do not like this solution as it duplicate omap hsmmc DT
specification from nokia n900 DTS file to board pdata-quirks file.

It means that in nokia n900 DTS file will be mmc information which will
not be used and this is not correct in the way how we use DTS files.

> Then when we have a generic binding for this we can move to use
> that.
> 
> > * missing DT support for ir-rx51 driver
> 
> I believe this still works the same as ever with platform_data if
> you completely disable multiarch. However, that's not a good
> solution, it's best to update it to use the generic
> drivers/pwm/pwm-omap-dmtimer.c.
> 
> I can take a look at this one no problem unless somebody else
> is already working on it.

It also needs porting driver to support multiarch. It you have time for
it, you can take it.

> > Plus, before removing board-rx51.c file we should backup or convert to
> > DT this C-state cpuidle table (to prevent its lost):
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mach-omap2/board-rx51.c#n62
> 
> Oh you mean just the table in the comments there?

Yes, that table in comments.

> We have board-rx51.c still available in git log so I think we
> have plenty of back up versions of that :)
> 
> $ git show v4.4:arch/arm/mach-omap2/board-rx51.c

I know, but how many users and developers are looking into git *history*
if they need to know what is missing in *current* kernel?

I think that removing board-rx51.c file would mean that table is lost
and everybody forget that this table needs to be ported to nokia n900
DTS file.

-- 
Pali Rohár
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux