Re: [PATCH 1/2] Put in supportframework for PR785 board.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 04 December 2008, Manikandan Pillai wrote:
> +config PR785
> +       bool "A Texas Instruments TPS6235X based Power Module"
> +       depends on I2C=y && MACH_OMAP3EVM=y && GENERIC_GPIO && (ARCH_OMAP

One more comment about that symbol:  as well as living in the
mach-omap2/Kconfig file, it should probably look more like 

	config OMAP3EVM_PR785
	depends on MACH_OMAP3EVM

Having the module isn't a function of I2C, and the other dependencies
are implicit in OMAP3 EVM support.  The name "PR785" should be scoped;
in this usage it's specific to that EVM.  Another vendor might have a
board with the same name, let's not confuse things.  :)

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux