On Tue, Sep 23, 2008 at 10:22:41AM +0530, Madhusudhan Chikkature (madhu.cr@xxxxxx) wrote: > >> > +/* > >> > + * Used to control the call to omap_hdq_get and omap_hdq_put. > >> > + * HDQ Protocol: Write the CMD|REG_address first, followed by > >> > + * the data wrire or read. > >> > + */ > >> > +static int init_trans; > >> > >> This variable is not protected against simultaneous master's access > >> afaics, isn't it possible to have multiple w1 masters on given board? > > > > Don't know much about 1-wire. Someone else should answer that. But I > > suppose we should protect it, yeah. > > We can not test that scenario on our board. But I guess we should protect it as 1-Wire protocol supports multiple access. Doesn't this variable tell how to operate on given w1 master device? In this case having two or more of them will force all masters to operate in given mode, which likely not what you want. I think it should live in per-master private data, and since this variable access is guarded by master's lock, it should be ok. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
