----- Original Message ----- From: "Felipe Balbi" <felipe.balbi@xxxxxxxxx> To: "ext Madhusudhan Chikkature" <madhu.cr@xxxxxx> Cc: <felipe.balbi@xxxxxxxxx>; "Evgeniy Polyakov" <johnpol@xxxxxxxxxxx>; <tony@xxxxxxxxxxx>; <linux-omap@xxxxxxxxxxxxxxx> Sent: Monday, September 22, 2008 8:07 PM Subject: Re: [PATCH]OMAP HDQ driver ioremap changes > On Mon, Sep 22, 2008 at 07:01:57PM +0530, ext Madhusudhan Chikkature wrote: >> >> ----- Original Message ----- >> From: "Felipe Balbi" <felipe.balbi@xxxxxxxxx> >> To: "ext Madhusudhan Chikkature" <madhu.cr@xxxxxx> >> Cc: "Evgeniy Polyakov" <johnpol@xxxxxxxxxxx>; <tony@xxxxxxxxxxx>; <linux-omap@xxxxxxxxxxxxxxx> >> Sent: Monday, September 22, 2008 6:57 PM >> Subject: Re: [PATCH]OMAP HDQ driver ioremap changes >> >> >> > On Mon, Sep 22, 2008 at 06:43:10PM +0530, ext Madhusudhan Chikkature wrote: >> >> Hi Evgeniy Polyakov, >> >> >> >> Thanks for the comments. I will incorporate them and send the patch again. My comments inlined. >> > >> > How about fixing it and later sending to mainline for integration ? >> >> Yes. I will do that. > > Really, that driver is a mess. Get the attached patch, break it into > proper smaller patches, see if it's really working since I just compile > tested, change the semaphore to mutex (in a separate patch), fix > comments to kernel-doc style, then you send a nice series fixing the > driver before sending the final driver to mainline. > > It's time to start doing things properly. It's really annoying have to > keep cleaning stuff after it's in-tree. Balbi, Please note that the driver patches were submitted to L-o as RFC initially and all the comments provided by the community are fixed before it is pushed by Tony. There would be a time gap between the day the patches are submitted and before Tony pushes the patches to the tree. Any valid comments provided then would get promptly fixed. This would definetely avoid cleaning stuff which is already in tree to whatever extent it is possible. Regards, Madhu > > -- > balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
