----- Original Message ----- From: "Felipe Balbi" <me@xxxxxxxxxxxxxxx> To: "Evgeniy Polyakov" <johnpol@xxxxxxxxxxx> Cc: "Felipe Balbi" <felipe.balbi@xxxxxxxxx>; "ext Madhusudhan Chikkature" <madhu.cr@xxxxxx>; <tony@xxxxxxxxxxx>; <linux-omap@xxxxxxxxxxxxxxx> Sent: Tuesday, September 23, 2008 7:54 AM Subject: Re: [PATCH]OMAP HDQ driver ioremap changes > On Tue, Sep 23, 2008 at 12:14:00AM +0400, Evgeniy Polyakov wrote: >> On Mon, Sep 22, 2008 at 05:37:41PM +0300, Felipe Balbi (felipe.balbi@xxxxxxxxx) wrote: >> > +/* >> > + * Used to control the call to omap_hdq_get and omap_hdq_put. >> > + * HDQ Protocol: Write the CMD|REG_address first, followed by >> > + * the data wrire or read. >> > + */ >> > +static int init_trans; >> >> This variable is not protected against simultaneous master's access >> afaics, isn't it possible to have multiple w1 masters on given board? > > Don't know much about 1-wire. Someone else should answer that. But I > suppose we should protect it, yeah. We can not test that scenario on our board. But I guess we should protect it as 1-Wire protocol supports multiple access. Regards, Madhu > > -- > balbi > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
