On Tue, Sep 23, 2008 at 12:14:00AM +0400, Evgeniy Polyakov wrote: > On Mon, Sep 22, 2008 at 05:37:41PM +0300, Felipe Balbi (felipe.balbi@xxxxxxxxx) wrote: > > +/* > > + * Used to control the call to omap_hdq_get and omap_hdq_put. > > + * HDQ Protocol: Write the CMD|REG_address first, followed by > > + * the data wrire or read. > > + */ > > +static int init_trans; > > This variable is not protected against simultaneous master's access > afaics, isn't it possible to have multiple w1 masters on given board? Don't know much about 1-wire. Someone else should answer that. But I suppose we should protect it, yeah. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html