On Mon, 2011-09-26 at 21:35 -0700, Linus Torvalds wrote: > On Mon, Sep 26, 2011 at 9:16 PM, Ian Kent <raven@xxxxxxxxxx> wrote: > > > > This case is the one were there is no existing directory yet for the > > automount (it's the age old original automount case where mount point > > directories never existed within the automount managed directory before > > being automounted). In this case we always want to automount regardless > > of the lookup flags. So returning -EISDIR should be conditional on also > > having a positive dentry. > > Ok. This all just makes me more conviced that the LOOKUP_NO_AUTOMOUNT > code is not even worth trying to salvage (ie not play any games with > the existing AT_NO_AUTOMOUNT flag and perhaps turning > !AT_SYMLINK_NOFOLLOW + !AT_NOAUTOMOUNT -> LOOKUP_AUTOMOUNT). That's > the case that never tested for d_inode being NULL, so it got the > autofs case wrong. Agreed. > > At some point we might want to expose an AT_AUTOMOUNT flag to user > space _if_ it turns out that glibc or somebody wants really wants it, > but the old flag clearly actually had a buggy implementation and > almost certainly isn't worth worrying about. Yes, I also thought that AT_NO_AUTOMOUNT would need to be removed and AT_AUTOMOUNT added as part of the change. But that can be done as a follow up. > > Of course, we'll have to see if there are any actual regression > reports in this area.. If something actually breaks, we may not have > all that many choices. But at least tentatively, I think we can plan > on applying the attached cleanup to just rip that out (it's already > effectively dead code apart from the buggy lack of d_inode testing, > since apart from d_inode, it never triggers unless the subsequent test > triggers).. Is there a source tree somewhere, I'm not sure now exactly what has been changed. I can run tests if I can get accurate source. Ian -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
