On Fri, 2011-09-23 at 11:33 +0100, David Howells wrote: > The only fault I've had reported against my original patches in this respect is > with ls, and that's fixed in userspace upstream now (libacl was using getxattr > when it should've been using lgetxattr). It has been mentioned that nautilus > (I think it was) may also broken - which makes sense as it's a file manager. > > The only fault I've had reported against Miklos's patch is the NFS4 pathwalk > during mount. If NFSv4 is the only concern, then Linus's solution is easily implementable. I don't have any problems with adding a LOOKUP_DIRECTORY flag to the NFSv4 mount path lookup call. My objections are due to the other cases that I pointed out, where Miklos's patch introduced changes in behaviour that IMO are unnecessary and incorrect. > Having thought it over some more, I'm leaning towards reverting Miklos's patch, > removing the do we/don't we logic from follow_automount() (or simplifying it) > and having the syscalls suppy the LOOKUP_NO_AUTOMOUNT flag as appropriate - > whatever is meant by 'appropriate'. I agree. That means the default behaviour is the correct one and we're only adding exceptions in cases where exposing the hidden directory is acceptable either to address an optimisation concern or an application regression. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
