On Fri, 23 Sep 2011 18:44:59 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Sep 23, 2011 at 6:30 PM, Ian Kent <raven@xxxxxxxxxx> wrote: > > > > Perhaps, but that allows modules to circumvent VFS policy which is what > > allowed this situation to come up in the first place. > > So, realistically, what's the downside of just adding LOOKUP_DIRECTORY > (or LOOKUP_OPEN) to the nfs_follow_remote_path() case? > There's certainly no danger in adding LOOKUP_DIRECTORY to that call. We are, after all, looking for a directory there. The problem is that that does not fully fix the NFS regression. NFS (and CIFS) has always allowed the automounting of submounts to trigger on stat() -- this is both before and after the d_automount patches went in. Miklos' patch changes this. The problem really boils down to this: The d_automount patches changed autofs' automount trigger behavior to be like that of NFS and CIFS. Miklos' patch reverts the behavior of autofs to pre-2.6.38 behavior, but it also changes NFS and CIFS in the same way, which is also a regression. If you want to go back to pre-2.6.38 behavior, then you really have no choice but to do re-introduce filesystem-specific behavior for automounting. The behavior of autofs was different from that of NFS and CIFS in earlier kernels. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
