On Mon, Sep 26, 2011 at 5:59 PM, Trond Myklebust
<Trond.Myklebust@xxxxxxxxxx> wrote:
>
> OK. Then how about something along the lines of the following patch
> (compile tested only)?
I would seriously suggest aiming for *minimal*.
So if it already has any of LOOKUP_DIRECTORY, LOOKUP_OPEN,
LOOKUP_CREATE or LOOKUP_PARENT, don't add LOOKUP_AUTOMOUNT - because
it's not adding anything.
We *have* to automount on those flags anyway. They are not like
LOOKUP_FOLLOW was, where the automount decision was just a random
(bad) choice.
>From a quick look, pretty much all of the cases you added
LOOKUP_AUTOMOUNT to were already implicit automount events. So I think
the two remaining ones are quotactl Q_QUOTAON case, bind mount in
do_looopback(), and the nfs_follow_remote_path() case.
Sure, we could add it to the others as some kind of "documentation"
thing, but I think that should be separate and is debatable to begin
with.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
